Mirrors/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2025-12-18 05:04:41 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Clarify NR.7 ("Don't make data members protected") (#2273)

Browse Source 
Made NR.7 ("Don't make all data members `protected`") clearer by removing the word "all".

Used the default formulation of C.133 ("Avoid `protected` data") as hyperlink text, linking to C.133. Used the old hyperlink text ("Make member data `public` or (preferably) `private`") as alternative formulation of C.133.
This commit is contained in:
Niels Dekker
2025-05-08 20:11:24 +02:00
committed by GitHub
parent 177b50eced
commit 21d6761a84
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
CppCoreGuidelines.md
View File

@@ -7773,6 +7773,8 @@ This kind of "vector" isn't meant to be used as a base class at all.
### <a name="Rh-protected"></a>C.133: Avoid `protected` data ### <a name="Rh-protected"></a>C.133: Avoid `protected` data
**Alternative formulation**: Make member data `public` or (preferably) `private`.
##### Reason ##### Reason
`protected` data is a source of complexity and errors. `protected` data is a source of complexity and errors.
@@ -20560,7 +20562,7 @@ Non-rule summary:
* [NR.4: Don't insist on placing each class definition in its own source file](#Rnr-lots-of-files) * [NR.4: Don't insist on placing each class definition in its own source file](#Rnr-lots-of-files)
* [NR.5: Don't use two-phase initialization](#Rnr-two-phase-init) * [NR.5: Don't use two-phase initialization](#Rnr-two-phase-init)
* [NR.6: Don't place all cleanup actions at the end of a function and `goto exit`](#Rnr-goto-exit) * [NR.6: Don't place all cleanup actions at the end of a function and `goto exit`](#Rnr-goto-exit)
* [NR.7: Don't make all data members `protected`](#Rnr-protected-data) * [NR.7: Don't make data members `protected`](#Rnr-protected-data)
* ??? * ???
### <a name="Rnr-top"></a>NR.1: Don't insist that all declarations should be at the top of a function ### <a name="Rnr-top"></a>NR.1: Don't insist that all declarations should be at the top of a function
@@ -20900,7 +20902,7 @@ and spot the bug.
* Use exceptions and [RAII](#Re-raii) * Use exceptions and [RAII](#Re-raii)
* for non-RAII resources, use [`finally`](#Re-finally). * for non-RAII resources, use [`finally`](#Re-finally).
### <a name="Rnr-protected-data"></a>NR.7: Don't make all data members `protected` ### <a name="Rnr-protected-data"></a>NR.7: Don't make data members `protected`
##### Reason ##### Reason
@@ -20914,7 +20916,7 @@ and spot the bug.
##### Alternative ##### Alternative
* [Make member data `public` or (preferably) `private`](#Rh-protected) * [Avoid `protected` data](#Rh-protected)
# <a name="S-references"></a>RF: References # <a name="S-references"></a>RF: References