diff --git a/build.rs b/build.rs index 7819a6a..c1eb5b0 100644 --- a/build.rs +++ b/build.rs @@ -21,13 +21,13 @@ fn generate_man() -> String { // This function is purposely stupid and redundant let man = render_man("mandoc", "./doc/rosenpass.1"); - if man.is_ok() { - return man.unwrap(); + if let Ok(man) = man { + return man; } let man = render_man("groff", "./doc/rosenpass.1"); - if man.is_ok() { - return man.unwrap(); + if let Ok(man) = man { + return man; } // TODO: Link to online manual here diff --git a/src/app_server.rs b/src/app_server.rs index a3cd96c..a315daf 100644 --- a/src/app_server.rs +++ b/src/app_server.rs @@ -99,7 +99,7 @@ impl SocketPtr { } pub fn send_to(&self, srv: &AppServer, buf: &[u8], addr: SocketAddr) -> anyhow::Result<()> { - self.get(srv).send_to(&buf, addr)?; + self.get(srv).send_to(buf, addr)?; Ok(()) } } @@ -294,13 +294,13 @@ impl HostPathDiscoveryEndpoint { pub fn send_scouting(&self, srv: &AppServer, buf: &[u8]) -> anyhow::Result<()> { let (addr_off, sock_off) = self.scouting_state.get(); - let mut addrs = (&self.addresses) + let mut addrs = (self.addresses) .iter() .enumerate() .cycle() .skip(addr_off) .take(self.addresses.len()); - let mut sockets = (&srv.sockets) + let mut sockets = (srv.sockets) .iter() .enumerate() .cycle() @@ -524,9 +524,11 @@ impl AppServer { use AppPollResult::*; use KeyOutputReason::*; match self.poll(&mut *rx)? { + #[allow(clippy::redundant_closure_call)] SendInitiation(peer) => tx_maybe_with!(peer, || self .crypt .initiate_handshake(peer.lower(), &mut *tx))?, + #[allow(clippy::redundant_closure_call)] SendRetransmission(peer) => tx_maybe_with!(peer, || self .crypt .retransmit_handshake(peer.lower(), &mut *tx))?,